linux-kernel - Re: [PATCH] Make kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060826153147.GB18092@kvack.org>
Date:	Sat, 26 Aug 2006 11:31:47 -0400
From:	Benjamin LaHaise <bcrl@...ck.org>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] Make kmem_cache_destroy() return void

On Sat, Aug 26, 2006 at 01:21:10AM +0400, Alexey Dobriyan wrote:
> un-, de-, -free, -destroy, -exit, etc functions should in general
> return void. Also,
> @@ -2411,7 +2410,6 @@ int kmem_cache_destroy(struct kmem_cache
>  		list_add(&cachep->next, &cache_chain);
>  		mutex_unlock(&cache_chain_mutex);
>  		unlock_cpu_hotplug();
> -		return 1;
>  	}
>  
>  	if (unlikely(cachep->flags & SLAB_DESTROY_BY_RCU))

Shouldn't this return, as otherwise there is a significant change in the 
code path followed.

		-ben
-- 
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@...ck.org>.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/