linux-kernel - Re: [PATCH RFC 4/6] Fix places where using %gs changes the usermode ABI.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200608271759.07055.ak@suse.de>
Date:	Sun, 27 Aug 2006 17:59:07 +0200
From:	Andi Kleen <ak@...e.de>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	linux-kernel@...r.kernel.org,
	Chuck Ebbert <76306.1226@...puserve.com>,
	Zachary Amsden <zach@...are.com>,
	Jan Beulich <jbeulich@...ell.com>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH RFC 4/6] Fix places where using %gs changes the usermode ABI.


> ===================================================================
> --- a/arch/i386/kernel/ptrace.c
> +++ b/arch/i386/kernel/ptrace.c
> @@ -94,13 +94,9 @@ static int putreg(struct task_struct *ch
>  				return -EIO;
>  			child->thread.fs = value;
>  			return 0;
> -		case GS:
> -			if (value && (value & 3) != 3)
> -				return -EIO;
> -			child->thread.gs = value;
> -			return 0;
>  		case DS:
>  		case ES:
> +		case GS:
>  			if (value && (value & 3) != 3)
>  				return -EIO;
>  			value &= 0xffff;
> @@ -132,8 +128,6 @@ static unsigned long getreg(struct task_
>  			retval = child->thread.fs;
>  			break;
>  		case GS:
> -			retval = child->thread.gs;
> -			break;

Didn't the eip/esp offsets change too?

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/