linux-kernel - Re: [PATCH 2.6.18-rc4 1/5] ieee1394: sbp2: workaround for write protect bit of Initio firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44F244B7.1070408@garzik.org>
Date:	Sun, 27 Aug 2006 21:19:51 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Linus Torvalds <torvalds@...l.org>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	Ben Collins <bcollins@...ntu.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.18-rc4 1/5] ieee1394: sbp2: workaround for write protect
 bit of Initio firmware

Linus Torvalds wrote:
> I don't think there really is _ever_ any reason to use the 10-byte version 
> if the 6-byte version is expected to work. Is there?

Yes, but not really important:  10-byte allows a 16-bit allocation 
length (additional data section), where 6-byte only allows 8-bit.

However, the mode pages the kernel requests from the device are normally 
<= 256 bytes.

In general, your intuition is correct.  use_10_for_foo is largely meant 
for the subclass of "SCSI" devices which often don't bother to implement 
the 6-byte commands, forcing the software driver to emulate 6-byte. 
use_10_for_foo allows the software driver to eliminate that in-kernel 
emulation code.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/