linux-kernel - Re: [PATCH -mm] Fix faulty HPET clocksource usage (fix for bug #7062)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060828143928.c6fc1b85.akpm@osdl.org>
Date:	Mon, 28 Aug 2006 14:39:28 -0700
From:	Andrew Morton <akpm@...l.org>
To:	john stultz <johnstul@...ibm.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, michael.olbrich@....net
Subject: Re: [PATCH -mm] Fix faulty HPET clocksource usage (fix for bug
 #7062)

On Mon, 28 Aug 2006 14:32:39 -0700
john stultz <johnstul@...ibm.com> wrote:

> Apparently some systems export valid HPET addresses, but hpet_enable()
> fails. Then when the HPET clocksource starts up, it only checks for a
> valid HPET address, and the result is a system where time does not
> advance.
> 
> See http://bugme.osdl.org/show_bug.cgi?id=7062 for details.
> 
> This patch just makes sure we better check that the HPET is functional
> before registering the HPET clocksource.
> 
> Signed-off-by: John Stultz <johnstul@...ibm.com>
> 
> diff --git a/arch/i386/kernel/hpet.c b/arch/i386/kernel/hpet.c
> index c6737c3..17647a5 100644
> --- a/arch/i386/kernel/hpet.c
> +++ b/arch/i386/kernel/hpet.c
> @@ -35,7 +35,7 @@ static int __init init_hpet_clocksource(
>  	void __iomem* hpet_base;
>  	u64 tmp;
>  
> -	if (!hpet_address)
> +	if (!is_hpet_enabled())
>  		return -ENODEV;
>  
>  	/* calculate the hpet address: */

Thanks.   This would be a 2.6.18 thing, wouldn't it?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/