[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <44F29BCD.3080408@zytor.com>
Date: Mon, 28 Aug 2006 00:31:25 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Alon Bar-Lev <alon.barlev@...il.com>
CC: Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...l.org>,
linux-kernel@...r.kernel.org, johninsd@....rr.com,
Matt_Domsch@...l.com
Subject: Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit
(ping)
Alon Bar-Lev wrote:
>
> Better patch.
> I've noticed that this code sets esi but then reference using si... So
> fixed to
> use esi (It worked so far since we are in low area... But I think using
> the same
> register type is cleaner...)
>
Totally pointless since we're in 16-bit mode (as is the "incl %esi")...
I guess it's "better" in the sense that if we run out of that we'll
crash due to a segment overrun... maybe (some BIOSes leave us
unknowningly in big real mode...)
-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists