[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060829122501.GA7814@infradead.org>
Date: Tue, 29 Aug 2006 13:25:01 +0100
From: Christoph Hellwig <hch@...radead.org>
To: David Howells <dhowells@...hat.com>
Cc: Christoph Hellwig <hch@...radead.org>,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
zippel@...ux-m68k.org
Subject: Re: [PATCH 17/17] BLOCK: Make it possible to disable the block layer [try #2]
On Tue, Aug 29, 2006 at 01:23:18PM +0100, David Howells wrote:
> Christoph Hellwig <hch@...radead.org> wrote:
>
> > Same as above. USB_STORAGE already selects scsi so it shouldn't need
> > to depend on block.
>
> Ah, you've got it the wrong way round.
>
> Because USB_STORAGE _selects_ SCSI rather than depending on it, even if SCSI
> is disabled, USB_STORAGE can be enabled, and that turns on CONFIG_SCSI, even
> if not all of its dependencies are available.
>
> Run "make allyesconfig" and then try to turn off CONFIG_SCSI without this...
Eeek. The easy fix is to change USB_STORAGE to depend on SCSI (*), but in
addition to that we should probably fix Kconfig aswell to adhere to
such constraints.
(*) that selects is really wrong to start with, the other scsi drivers don't
select scsi either.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists