linux-kernel - Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29516.1156859236@warthog.cambridge.redhat.com>
Date:	Tue, 29 Aug 2006 14:47:16 +0100
From:	David Howells <dhowells@...hat.com>
To:	Arnd Bergmann <arnd.bergmann@...ibm.com>
Cc:	David Howells <dhowells@...hat.com>,
	Sam Ravnborg <sam@...nborg.org>, axboe@...nel.dk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/18] [PATCH] BLOCK: Separate the bounce buffering code from the highmem code [try #4] 

Arnd Bergmann <arnd.bergmann@...ibm.com> wrote:

> You could write it as
> 
> bounce-$(CONFIG_MMU) += bounce.o
> obj-$(CONFIG_BLOCK)  += $(bounce-y)

I could, yes, but why?  What does it buy?  I think this:

	ifeq ($(CONFIG_MMU)$(CONFIG_BLOCK),yy)
	obj-y += bounce.o
	endif

is clearer.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/