linux-kernel - Re: [PATCH] kthread: saa7134-tvaudio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1156886546.5408.191.camel@localhost.localdomain>
Date:	Tue, 29 Aug 2006 14:22:26 -0700
From:	Dave Hansen <haveblue@...ibm.com>
To:	Sukadev Bhattiprolu <sukadev@...ibm.com>
Cc:	kraxel@...esex.org, Andrew Morton <akpm@...l.org>, clg@...ibm.com,
	serue@...ibm.com, Containers@...ts.osdl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kthread: saa7134-tvaudio.c

On Tue, 2006-08-29 at 14:15 -0700, Sukadev Bhattiprolu wrote:
> @@ -1004,15 +1002,16 @@ int saa7134_tvaudio_init2(struct saa7134
>  		break;
>  	}
>  
> -	dev->thread.pid = -1;
> +	dev->thread.task = NULL;
>  	if (my_thread) {
...

This is _really_ minor, but I think dev is kzmalloc()'d.  I haven't
examined it closely enough to tell if these devices get reused, but this
one _might_ be unnecessary.  Certainly no big deal either way, and it
certainly doesn't make anything worse.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/