linux-kernel - [PATCH] IPMI: fix occasional oops on module unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20060830174251.GA20983@localdomain>
Date:	Wed, 30 Aug 2006 12:42:51 -0500
From:	Corey Minyard <minyard@....org>
To:	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Cc:	Olaf Kirch <okir@...e.de>,
	OpenIPMI Developers <openipmi-developer@...ts.sourceforge.net>
Subject: [PATCH] IPMI: fix occasional oops on module unload


Olaf Kirch of SuSE tracked down a problem where module unloads of
the IPMI driver would occasionally result in Oopses.  He tracked
that down to a variable that wasn't always initialized properly
in some situations.  This patch initializes that variable.
Olaf sent a patch that kzalloc-ed the data, but this structure
is large enough that I would perfer to not do that.
Thanks Olaf!

Signed-off-by: Corey Minyard <minyard@....org>
Cc: Olaf Kirch <okir@...e.de>

Index: linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- linux-2.6.17.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ linux-2.6.17/drivers/char/ipmi/ipmi_msghandler.c
@@ -3470,6 +3470,7 @@ struct ipmi_recv_msg *ipmi_alloc_recv_ms
 
 	rv = kmalloc(sizeof(struct ipmi_recv_msg), GFP_ATOMIC);
 	if (rv) {
+		rv->user = NULL;
 		rv->done = free_recv_msg;
 		atomic_inc(&recv_msg_inuse_count);
 	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/