linux-kernel - Re: [BUG] 2.6.18-rc4-mm3 x86_64-mm-spin-irqs-enabled causes problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20060829171453.3921337e.akpm@osdl.org>
Date:	Tue, 29 Aug 2006 17:14:53 -0700
From:	Andrew Morton <akpm@...l.org>
To:	kmannth@...ibm.com
Cc:	lkml <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
	efalk@...gle.com
Subject: Re: [BUG] 2.6.18-rc4-mm3 x86_64-mm-spin-irqs-enabled causes
 problems

On Tue, 29 Aug 2006 16:59:36 -0700
keith mannthey <kmannth@...ibm.com> wrote:

>   I moved to mm2 to mm3 and had trouble booting again with my hardware.
> In -mm3 the kernel boots but about the time init starts the whole box
> just stops doing anything.  Sysrq works and I dumped the tasks but
> nothing look too far out of place.  
> 
> I did a bisection of -mm3 and found x86_64-mm-spin-irqs-enabled.patch to
> be the cause. 

Yes, Hugh was hitting that today and the following has emerged...

From: Andrew Morton <akpm@...l.org>

Signed-off-by: Andrew Morton <akpm@...l.org>
---

 include/asm-x86_64/spinlock.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -puN include/asm-x86_64/spinlock.h~x86_64-mm-spin-irqs-enabled-fix include/asm-x86_64/spinlock.h
--- a/include/asm-x86_64/spinlock.h~x86_64-mm-spin-irqs-enabled-fix
+++ a/include/asm-x86_64/spinlock.h
@@ -51,7 +51,7 @@ static inline void __raw_spin_lock_flags
 {
 	asm volatile(
 		"\n1:\t"
-		LOCK_PREFIX "; decb %0\n\t"
+		LOCK_PREFIX "; decl %0\n\t"
 		"js 2f\n\t"
 		LOCK_SECTION_START("")
 		"2:\t"
@@ -60,7 +60,7 @@ static inline void __raw_spin_lock_flags
 		"sti\n\t"
 		"3:\t"
 		"rep;nop\n\t"
-		"cmpb $0, %0\n\t"
+		"cmpl $0, %0\n\t"
 		"jle 3b\n\t"
 		"cli\n\t"
 		"jmp 1b\n"
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/