[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060830222303.11b35276@localhost>
Date: Wed, 30 Aug 2006 22:23:03 +0300
From: Alon Bar-Lev <alon.barlev@...il.com>
To: "H. Peter Anvin" <hpa@...or.com>
Cc: Andi Kleen <ak@...e.de>, Matt Domsch <Matt_Domsch@...l.com>,
Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
johninsd@....rr.com
Subject: Re: [PATCH] THE LINUX/I386 BOOT PROTOCOL - Breaking the 256 limit
(ping)
On Wed, 30 Aug 2006 11:59:40 -0700
"H. Peter Anvin" <hpa@...or.com> wrote:
> Alon Bar-Lev wrote:
> >
> > This is not entirely true...
> > All architectures sets saved_command_line variable...
> > So I can add __init to the saved_command_line and
> > copy its contents into kmalloced persistence_command_line at
> > main.c.
> >
>
> My opinion is that you should change saved_command_line (which
> already implies a copy) to be the kmalloc'd version and call the
> fixed-sized buffer something else.
>
> -hpa
Changing saved_command_line is a modification to all
architectures... They all modify this variable...
So, should I submit a patch to all architectures? How can I test this?
Also for i386 the code is assembly... So I can modify the code to write
into a __init buffer and then kmalloc in setup.c.
Please instruct me how to proceed...
Best Regards,
Alon Bar-Lev.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists