linux-kernel - Re: [PATCH 19/19] BLOCK: Make it possible to disable the block layer [try #6]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060830142045.c87f341e.akpm@osdl.org>
Date:	Wed, 30 Aug 2006 14:20:45 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Trond Myklebust <trond.myklebust@....uio.no>
Cc:	David Howells <dhowells@...hat.com>, axboe@...nel.dk,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 19/19] BLOCK: Make it possible to disable the block
 layer [try #6]

On Wed, 30 Aug 2006 17:06:39 -0400
Trond Myklebust <trond.myklebust@....uio.no> wrote:

> > This function is misnamed and is implemented in the wrong place.  It's not
> > really a block thing at all.  If/when/soon NFS starts to implement it and
> > call it, things will need to be renamed and reshuffled.
> 
> Already done in the NFS git tree. See attached patch.

Right, I saw that, didn't know that you'd merged it yet.  Ho hum, yet
another reject to fix up.

I think your patch is a bit minimal: at adds blk_congestion_end() whereas
it'd make better sense longer-term to remove blk_congestion_wait() and
blk_congestion_end() altogether, replace them with something which is
somewhere else and which doesn't mention "blk".  I expected this to be done
four years ago ;)

But not now.  Nobody's allowed to touch anything else!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/