| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Pine.LNX.4.64.0608301550090.27779@g5.osdl.org> Date: Wed, 30 Aug 2006 15:53:50 -0700 (PDT) From: Linus Torvalds <torvalds@...l.org> To: Andrew Morton <akpm@...l.org> cc: Dave Airlie <airlied@...ux.ie>, linux-kernel@...r.kernel.org Subject: Re: [FOR 2.6.18 FIX][PATCH] drm: radeon flush TCL VAP for vertex program enable/disable On Wed, 30 Aug 2006, Andrew Morton wrote: > > That's a somewhat weird-looking patch. It adds code which is quite > dissimilar from all the other cases in that switch statement. It looks ok to me, although you have to look into the caller to see why it does what it does. It would be "prettier" if it changed the size and data of the incoming packet instead, but the code as is isn't actually set up to be able to do that (the size setup and verification stuff is done before the fixup). That said, I'd have expected that the VAP state flush is really something that the _client_ should do when it generates the commands, not the kernel after the fact. Although maybe the kernel could keep track of whether the flush is needed at all, and since we apparently allow untrusted generation of packets, maybe this is the right approach.. Anyway, the patch doesn't look _wrong_ to me, although it does seem to break the abstraction rules a bit. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists