linux-kernel - Re: [PATCH 1/7] introduce atomic_dec_and_lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0608301156010.6762@scrub.home>
Date:	Wed, 30 Aug 2006 11:59:48 +0200 (CEST)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Kirill Korotaev <dev@...ru>
cc:	Andrew Morton <akpm@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Christoph Hellwig <hch@...radead.org>,
	Pavel Emelianov <xemul@...nvz.org>,
	Andrey Savochkin <saw@...ru>, devel@...nvz.org,
	Rik van Riel <riel@...hat.com>, Andi Kleen <ak@...e.de>,
	Oleg Nesterov <oleg@...sign.ru>,
	Alexey Dobriyan <adobriyan@...l.ru>,
	Matt Helsley <matthltc@...ibm.com>,
	CKRM-Tech <ckrm-tech@...ts.sourceforge.net>
Subject: Re: [PATCH 1/7] introduce atomic_dec_and_lock_irqsave()

Hi,

On Tue, 29 Aug 2006, Kirill Korotaev wrote:

> --- ./kernel/user.c.dlirq	2006-07-10 12:39:20.000000000 +0400
> +++ ./kernel/user.c	2006-08-28 11:08:56.000000000 +0400
> @@ -108,15 +108,12 @@ void free_uid(struct user_struct *up)
> 	if (!up)
> 		return;
> 
> -	local_irq_save(flags);
> -	if (atomic_dec_and_lock(&up->__count, &uidhash_lock)) {
> +	if (atomic_dec_and_lock_irqsave(&up->__count, &uidhash_lock, flags)) {
> 		uid_hash_remove(up);
> 		spin_unlock_irqrestore(&uidhash_lock, flags);
> 		key_put(up->uid_keyring);
> 		key_put(up->session_keyring);
> 		kmem_cache_free(uid_cachep, up);
> -	} else {
> -		local_irq_restore(flags);
> 	}
> }

Why does this need protection against interrupts?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/