linux-kernel - Re: [PATCH 7/8] Implement smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157027758.12949.327.camel@localhost.localdomain>
Date:	Thu, 31 Aug 2006 13:35:58 +0100
From:	Ian Campbell <Ian.Campbell@...Source.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	linux-kernel@...r.kernel.org,
	Chuck Ebbert <76306.1226@...puserve.com>,
	Zachary Amsden <zach@...are.com>,
	Jan Beulich <jbeulich@...ell.com>, Andi Kleen <ak@...e.de>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.

Hi Jeremy,

On Wed, 2006-08-30 at 16:52 -0700, Jeremy Fitzhardinge wrote:
> --- a/arch/i386/kernel/cpu/common.c
> +++ b/arch/i386/kernel/cpu/common.c@@ -664,7 +664,7 @@ static inline void set_kernel_gs(void)
>  /* Initialize the CPU's GDT and PDA */
>  static __cpuinit void init_gdt(void)
>  {
> -       int cpu = smp_processor_id();
> +       int cpu = early_smp_processor_id();
>         struct task_struct *curr = current;
>         struct Xgt_desc_struct *cpu_gdt_descr = &per_cpu(cpu_gdt_descr, cpu);
>         __u32 stk16_off = (__u32)&per_cpu(cpu_16bit_stack, cpu); 

This doesn't compile for me if CONFIG_SMP=n

          LD      .tmp_vmlinux1
        arch/i386/kernel/built-in.o: In function `cpu_init':
        (.init.text+0x1eda): undefined reference to `early_smp_processor_id'
        arch/i386/kernel/built-in.o: In function `cpu_init':
        (.init.text+0x1f11): undefined reference to `early_smp_processor_id'
        
smp_processor_id() is defined for !SMP in include/linux/smp.h, I don't
know if it would be appropriate to add early_smp_processor_id() there
since it seems i386 specific. asm/smp.h isn't included by linux/smp.h
when !SMP but you could add an explicit include to common.c I suppose.

Ian.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/