lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.61.0608311929100.19403@yvahk01.tjqt.qr>
Date:	Thu, 31 Aug 2006 19:30:00 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Steven Whitehouse <swhiteho@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Russell Cattelan <cattelan@...hat.com>,
	David Teigland <teigland@...hat.com>,
	Ingo Molnar <mingo@...e.hu>, hch@...radead.org
Subject: Re: [PATCH 01/16] GFS2: Core header files

>> 
>or you could argue that the addition of a space (i.e. v. 2) would be
>correct since its an abbreviation, but point taken and I'll clean it up
>shortly.

Or spell it out, as in many GPL headers.

>> >+	/* Quota stuff */
>> >+
>> >+	struct gfs2_quota_data *al_qd[4];
>> 
>> What four quotas can there be? Use the MAXQUOTAS macro if feasible.
>> 
>[...]
>As a result there are the overall user/group limits and the local
>differences which are saved to by synced back to the master quota
>information, hence four of them.

Well, al_qd[2*MAXQUOTAS] then.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ