linux-kernel - Re: [PATCH 7/8] Implement smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Aug 2006 14:39:40 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ian Campbell <Ian.Campbell@...Source.com>
CC:	linux-kernel@...r.kernel.org,
	Chuck Ebbert <76306.1226@...puserve.com>,
	Zachary Amsden <zach@...are.com>,
	Jan Beulich <jbeulich@...ell.com>, Andi Kleen <ak@...e.de>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH 7/8] Implement smp_processor_id() with the PDA.

Ian Campbell wrote:
> Are you sure that works? When I tried it didn't. I think because
> asm/smp.h isn't included by linux/smp.h for !SMP.
>   

Nah, testing is overrated.

> I needed the below to make it work, but including linux/smp.h and
> asm/smp.h in the same file smells a bit fishy to me... Probably
> acceptable for now if you are thinking of redoing SMP processor bringup
> anyway.
>   

That looks OK for now.  Rearranging CPU bringup looks a little bit 
complex to do immediately, so this seems like a reasonable fix for now.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/