linux-kernel - Re: [PATCH] VIA IRQ quirk fixup only in XT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44F5B933.2010608@gentoo.org>
Date:	Wed, 30 Aug 2006 12:13:39 -0400
From:	Daniel Drake <dsd@...too.org>
To:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
CC:	bjorn.helgaas@...com, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andrew Morton <akpm@...l.org>, Chris Wedgwood <cw@...f.org>,
	greg@...ah.com, jeff@...zik.org, harmon@....edu
Subject: Re: [PATCH] VIA IRQ quirk fixup only in XT_PIC mode Take 2

Sergio Monteiro Basto wrote:
>> It does look like this patch was under discussion of being reverted 
>> before. See http://lkml.org/lkml/2005/9/26/183
> 
> To be honest, I prefer put again this :
> 
>  +#ifdef CONFIG_X86_IO_APIC
>  +      if (nr_ioapics && !skip_ioapic_setup)
>  +              return;
>  +#endif
>  +#ifdef CONFIG_ACPI
>  +      if (acpi_irq_model != ACPI_IRQ_MODEL_PIC)
>  +              return;
>  +#endif

Isn't this exactly the same as what was being suggested?

> about Linus suggestion : 
> -	new_irq = dev->irq & 0xf;
> +	new_irq = dev->irq;
> +	if (!new_irq || new_irq >= 15)
> +		return;
> 
> no, we have problem with VIA SATA controllers which have irq lower than
> 15 

Any chance you can provide a link to this example so that we can 
document the decision in the commit message?

Thanks,
Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/