linux-kernel - Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <44F78687.7080805@microgate.com>
Date:	Thu, 31 Aug 2006 20:01:59 -0500
From:	Paul Fulghum <paulkf@...rogate.com>
To:	Eric Sesterhenn <snakebyte@....de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [Patch] Uninitialized variable in drivers/net/wan/syncppp.c

Eric Sesterhenn wrote:
> Thanks for clarification. Here is an updated patch, which has the advantage
> of also silencing the gcc warning.
> 
> For len equal to 4, we never call sppp_lcp_conf_parse_options(),
> therefore rmagic does not get initialized.
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@....de>
> 
> --- linux-2.6.18-rc5/drivers/net/wan/syncppp.c.orig	2006-09-01 02:16:18.000000000 +0200
> +++ linux-2.6.18-rc5/drivers/net/wan/syncppp.c	2006-09-01 02:16:40.000000000 +0200
> @@ -469,7 +469,7 @@ static void sppp_lcp_input (struct sppp 
>  	struct net_device *dev = sp->pp_if;
>  	int len = skb->len;
>  	u8 *p, opt[6];
> -	u32 rmagic;
> +	u32 rmagic = 0;
>  
>  	if (!pskb_may_pull(skb, sizeof(struct lcp_header))) {
>  		if (sp->pp_flags & PP_DEBUG)

Acked-by: Paul Fulghum <paulkf@...rogate.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/