linux-kernel - Re: [Patch] Uninitialized variable in drivers/scsi/ncr53c8xx.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1157125556.3951.2.camel@alice>
Date:	Fri, 01 Sep 2006 17:45:56 +0200
From:	Eric Sesterhenn <snakebyte@....de>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, matthew@....cx
Subject: Re: [Patch] Uninitialized variable in drivers/scsi/ncr53c8xx.c

On Thu, 2006-08-31 at 23:00 -0700, Andrew Morton wrote:
> On Fri, 01 Sep 2006 01:29:12 +0200
> Eric Sesterhenn <snakebyte@....de> wrote:
> 
> > hi,
> > 
> > this was spotted by coverity (id #880).
> > We use simple_strtoul() earlier to initialize pe,
> > if the function fails, it also does not initialize it.
> > Therefore we should initialize it ourselves, so the check
> > in the OPT_TAGS case "if (pe && *pe == '/')" makes sense, and
> > actually makes the command line parsing more robust.
> > 
> > Signed-off-by: Eric Sesterhenn <snakebyte@....de>
> 
> simple_strtoul() always initialises `pe'.

D'oh. But i think we should apply the patch nevertheless,
to make the parsing code more robust, in case the command line is
screwed up (and simple_strtoul() is never called).

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/