linux-kernel - Re: [patch 4/9] Guest page hinting: volatile swap cache.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1157125939.28577.100.camel@localhost.localdomain>
Date:	Fri, 01 Sep 2006 08:52:19 -0700
From:	Dave Hansen <haveblue@...ibm.com>
To:	schwidefsky@...ibm.com
Cc:	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
	akpm@...l.org, nickpiggin@...oo.com.au, frankeh@...son.ibm.com,
	rhim@...gateh.edu
Subject: Re: [patch 4/9] Guest page hinting: volatile swap cache.

On Fri, 2006-09-01 at 17:37 +0200, Martin Schwidefsky wrote:
> On Fri, 2006-09-01 at 08:04 -0700, Dave Hansen wrote:
> > > +EXPORT_SYMBOL(find_get_page_nodiscard);
> > > +
> > > +#endif
> > 
> > Is it worth having another full copy of find_get_page()?  What about a
> > "nodiscard" argument?
> 
> That is a hard call to make. I really tried hard to avoid adding any
> overhead to a system running without the feature.

The overhead being the extra (potentially unused) argument to the
function?  Plus, that the function isn't inlined and thus will be unable
to have its argument optimized away?

In the worse case, we're talking about the cost of saving and restoring
the contents of a single register to the stack.  In other arches, we're
talking about the push of an immediate on the stack for the call.

Yeah, it is a hard call to make, especially if you're aiming for
zero-impact.

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/