linux-kernel - Re: [NFS] [PATCH 018 of 19] knfsd: lockd: fix use of h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157126751.5632.54.camel@localhost>
Date:	Fri, 01 Sep 2006 12:05:51 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	NeilBrown <neilb@...e.de>
Cc:	Andrew Morton <akpm@...l.org>, Olaf Kirch <okir@...e.de>,
	nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [NFS] [PATCH 018 of 19] knfsd: lockd: fix use of h_nextrebind

On Fri, 2006-09-01 at 14:39 +1000, NeilBrown wrote:
> From: Olaf Kirch <okir@...e.de>
> 
>   nlmclnt_recovery would try to force a portmap rebind by setting
>   host->h_nextrebind to 0. The right thing to do here is to set it
>   to the current time.

Could we instead just add a routine nlm_force_rebind_host() into host.c?

> Signed-off-by: okir@...e.de
> Signed-off-by: Neil Brown <neilb@...e.de>
> 
> ### Diffstat output
>  ./fs/lockd/clntlock.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff .prev/fs/lockd/clntlock.c ./fs/lockd/clntlock.c
> --- .prev/fs/lockd/clntlock.c	2006-08-31 17:02:23.000000000 +1000
> +++ ./fs/lockd/clntlock.c	2006-09-01 12:19:55.000000000 +1000
> @@ -184,7 +184,7 @@ restart:
>  	/* Force a portmap getport - the peer's lockd will
>  	 * most likely end up on a different port.
>  	 */
> -	host->h_nextrebind = 0;
> +	host->h_nextrebind = jiffies;
>  	nlm_rebind_host(host);
>  
>  	/* First, reclaim all locks that have been granted. */
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> NFS maillist  -  NFS@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/