linux-kernel - Re: 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060901101340.962150cb.akpm@osdl.org>
Date:	Fri, 1 Sep 2006 10:13:40 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Tom Tucker <tom@...ngridcomputing.com>,
	Steve Wise <swise@...ngridcomputing.com>,
	Roland Dreier <rolandd@...co.com>,
	linux-kernel@...r.kernel.org, openib-general@...nib.org
Subject: Re: 2.6.18-rc5-mm1: drivers/infiniband/hw/amso1100/c2.c compile
 error

On Fri, 1 Sep 2006 18:00:23 +0200
Adrian Bunk <bunk@...sta.de> wrote:

> On Fri, Sep 01, 2006 at 01:58:18AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc4-mm3:
> >...
> > +amso1100-build-fix.patch
> > 
> >  Fix git-infiniband.patch
> >...
> 
> This causes the following compile error on i386:
> 
> <--  snip  -->
> 
> ...
>   CC      drivers/infiniband/hw/amso1100/c2.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/infiniband/hw/amso1100/c2.c: In function ‘c2_tx_ring_alloc’:
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/drivers/infiniband/hw/amso1100/c2.c:133: error: implicit declaration of function ‘__raw_writeq’
> make[4]: *** [drivers/infiniband/hw/amso1100/c2.o] Error 1
> 

That would have been me cheerfully deleting stuff because it didn't build
on powerpc.

> 
> There seems to be some confusion regarding whether __raw_writeq() is 
> considered a platform independent API.
> 

It appears to be undocumented and uncommented hence it's not an API
_at all_, is it?

What's __raw_writeq() supposed to do, anyway?  On alpha it's writeq()
without an mb().  On parisc it's writeq() only the data is byte-reversed. 
On sparc64() it's incomprehensible.  On everything else it's writeq().

What a crock.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/