| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20060902231509.GC13031@elf.ucw.cz> Date: Sun, 3 Sep 2006 01:15:10 +0200 From: Pavel Machek <pavel@....cz> To: "Randy.Dunlap" <rdunlap@...otime.net> Cc: Takashi Iwai <tiwai@...e.de>, Andrew Morton <akpm@...l.org>, kernel list <linux-kernel@...r.kernel.org>, perex@...e.cz, alsa-devel@...a-project.org, pshou@...ltek.com.tw Subject: Re: CodingStyle (was: Re: sound/pci/hda/intel_hda: small cleanups) Hi! > > Hm, it looks rather like a personal preference. > > IMHO, it's harder to read without space... > > We have been tending toward not using space in cases like this > (in my unscientific memory-based survey). > > So, just this morning I have seen questions and opinions about > the following that could (or could not) use more documentation > or codification and I'm sure that we could easily find more, > but do we want to codify Everything?? > > > 1. Kconfig help text should be indented (it's not indented in the > GFS2 patches) > > 2. if (!condition1) /* no space between ! and condition1 */ > > 3. don't use C99-style // comments > > 4. unsigned int bitfield :<nr_bits>; Looks reasonable to me. Will you do the patch or should I ? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- VGER BF report: U 0.489855 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists