linux-kernel - Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200609020338.54932.david-b@pacbell.net>
Date:	Sat, 2 Sep 2006 03:38:54 -0700
From:	David Brownell <david-b@...bell.net>
To:	linux-usb-devel@...ts.sourceforge.net
Cc:	Arnd Bergmann <arnd@...db.de>,
	David Hollis <dhollis@...ehollis.com>, support@...chip.com,
	dbrownell@...rs.sourceforge.net, linux-kernel@...r.kernel.org,
	Michael Helmling <supermihi@....de>
Subject: Re: [linux-usb-devel] [PATCH] driver for mcs7830 (aka DeLOCK) USB ethernet adapter

On Sunday 20 August 2006 1:07 pm, Arnd Bergmann wrote:
> This driver adds support for the DeLOCK USB ethernet adapter
> and potentially others based on the MosChip MCS7830 chip.
> 
> It is based on the usbnet and asix drivers as well as the
> original device driver provided by MosChip, which in turn
> was based on the usbnet driver.
> 
> It has been tested successfully on an OHCI, but interestingly
> there seems to be a problem with the mcs7830 when connected to
> the ICH6/EHCI in my thinkpad: it keeps receiving lots of
> broken packets in the RX interrupt.

That is, the "status" polling which you disabled??  If so, please
update this comment ...

> The problem goes away when 
> I'm using an active USB hub, so I assume it's not related to
> the device driver, but rather to the hardware.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks basically OK to me, although I'd rather see the two patches
you posted on 27-August be merged into it before an upstream merge.
(To use normal MII constants, and handle max size frames.)


> ---
> 
> This version incorporates a few cleanups from myself an changes
> based on comments from David Hollis. 

He has more experience than I do with respect to these sorts of
real Ethernet adapters and usbnet.  :)

Speaking of which ... isnt this driver missing a hook to make
the MII stuff visible through ethtool?

- Dave

> In particular, it now has 
> 
> - an rx_fixup function that removes an out-of-band data byte
>   from each received packet.
> - got rid of the status function, which did not do the right thing
>   and is not needed in this driver.
> - has a working set_multicast function, although that one always
>   needs to set allmulticast mode in order to get the chip to
>   receive any frames.
> - doesn't use a private mutex in its mii functions, that functionality
>   is added in a separate patch to usbnet.
> 
> Please merge the driver in 2.6.19!
> 
>  drivers/usb/net/Kconfig   |    8
>  drivers/usb/net/Makefile  |    1
>  drivers/usb/net/mcs7830.c |  474 ++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 483 insertions(+)
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/