linux-kernel - Re: [PATCH] Vicam driver, device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157220743.15841.118.camel@praia>
Date:	Sat, 02 Sep 2006 15:12:22 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Bas Bloemsaat <bas.bloemsaat@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Vicam driver, device

Hi, Blas,

Em Sáb, 2006-09-02 às 20:01 +0200, Bas Bloemsaat escreveu:
> Hi,
> 
> I have an old webcam, a Compro PS39U. By windows it's recognized as
> vicam and works with the vicam driver. With Linux it didn't work.
> lsusb showed that it identifies different than camera's recognized by
> the vicam driver. So I added the usb id to vicam.c, and it now
> produces images through the driver under Linux too. It's still a
> shitty camera though.
> 
> I'm submitting the change, maybe someone else has this camera and
> want's to use it.

Although this is really a trivial patch, it would be nice if you can
sign your patch (on our wiki you can have more info about patch
submission procedure:
http://linuxtv.org/v4lwiki/index.php/How_to_submit_patches). Basically,
you should send at the email a line with:
	Signed-off-by: Your name <name@...rsite.com>

Also, it would be nice if you add a comment above the new entry at vicam
PCI table a short comment describing the new device, like, for example:

/* Compro PS39U */

> 
> Regards,
> Bas
> 
> --- drivers/media/video/usbvideo/vicam.c	2006-08-23 23:16:33.000000000 +0200
> +++ drivers/media/video/usbvideo/vicam.c.compro	2006-09-02
> 19:45:20.000000000 +0200
> @@ -60,6 +60,8 @@
>  /* Define these values to match your device */
>  #define USB_VICAM_VENDOR_ID	0x04c1
>  #define USB_VICAM_PRODUCT_ID	0x009d
> +#define USB_COMPRO_VENDOR_ID	0x0602
> +#define USB_COMPRO_PRODUCT_ID	0x1001
> 
>  #define VICAM_BYTES_PER_PIXEL   3
>  #define VICAM_MAX_READ_SIZE     (512*242+128)
> @@ -1254,6 +1256,7 @@
>  /* table of devices that work with this driver */
>  static struct usb_device_id vicam_table[] = {
>  	{USB_DEVICE(USB_VICAM_VENDOR_ID, USB_VICAM_PRODUCT_ID)},
> +	{USB_DEVICE(USB_COMPRO_VENDOR_ID, USB_COMPRO_PRODUCT_ID)},
>  	{}			/* Terminating entry */
>  };
Cheers, 
Mauro.


-- 
VGER BF report: U 0.5
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/