linux-kernel - [RFC/PATCH-mm] i8042: activate panic blink only in X

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 2 Sep 2006 23:20:36 -0400
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...l.org>, Grant Coady <gcoady.lk@...il.com>
Subject: [RFC/PATCH-mm] i8042: activate panic blink only in X

Hi,

Here is an attempt to make panicblink only active in X so there is a
chance of keyboard still working after panic in text console. Any reason
why is should not be done this way?

-- 
Dmitry

Input: i8042 - blink keyboard LEDs during panic only when in X

This gives keyboard a chance to work in text console so user
can attempt to exctract more useful data form crashed box
(for example some backtraces from SysRq)

Signed-off-by: Dmitry Torokhov <dtor@...l.ru>
---

 drivers/input/serio/i8042.c |   10 ++++++++++
 1 files changed, 10 insertions(+)

Index: work/drivers/input/serio/i8042.c
===================================================================
--- work.orig/drivers/input/serio/i8042.c
+++ work/drivers/input/serio/i8042.c
@@ -20,6 +20,7 @@
 #include <linux/err.h>
 #include <linux/rcupdate.h>
 #include <linux/platform_device.h>
+#include <linux/vt_kern.h>
 
 #include <asm/io.h>
 
@@ -831,6 +832,15 @@ static long i8042_panic_blink(long count
 	static char led;
 
 	/*
+	 * Only blink while in X because it messes up scrollback in console
+	 * preventing users to see the entire oops.
+	 */
+#ifdef CONFIG_HW_CONSOLE
+	if (vc_cons[fg_console].d->vc_mode != KD_GRAPHICS)
+		return 0;
+#endif
+
+	/*
 	 * We expect frequency to be about 1/2s. KDB uses about 1s.
 	 * Make sure they are different.
 	 */

-- 
VGER BF report: H 0.00257812
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/