linux-kernel - Re: [PATCH] Vicam driver, device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <44FA9493.1090207@gmail.com>
Date:	Sun, 03 Sep 2006 10:38:43 +0200
From:	Bas Bloemsaat <bas.bloemsaat@...il.com>
To:	mchehab@...radead.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Vicam driver, device

Hi,

> Although this is really a trivial patch, it would be nice if you can
> sign your patch (on our wiki you can have more info about patch
> 
> Also, it would be nice if you add a comment above the new entry at vicam
> PCI table a short comment describing the new device, like, for example:
Done. I put a line under the current one describing the cam it was developed for.

And mailed the text without wrapping (thanks to Pavel for bringing that to my attention).

Regards,
Bas

Description:
Trivial patch to make Compro PS39U WebCam work with linux by using the vicam driver.
The camera is just a vicam with another USB ID, so I added that ID to the driver, and it works now.

Signed-off-by: Bas Bloemsaat <bas.bloemsaat@...il.com>


--- drivers/media/video/usbvideo/vicam.c.org	2006-09-03 10:19:06.000000000 +0200
+++ drivers/media/video/usbvideo/vicam.c	2006-09-03 10:22:52.000000000 +0200
@@ -7,6 +7,7 @@
   *                    Monroe Williams (monroe@...ox.com)
   *
   * Supports 3COM HomeConnect PC Digital WebCam
+ * Supports Compro PS39U WebCam
   *
   * This program is free software; you can redistribute it and/or modify
   * it under the terms of the GNU General Public License as published by
@@ -60,6 +61,8 @@
  /* Define these values to match your device */
  #define USB_VICAM_VENDOR_ID	0x04c1
  #define USB_VICAM_PRODUCT_ID	0x009d
+#define USB_COMPRO_VENDOR_ID	0x0602
+#define USB_COMPRO_PRODUCT_ID	0x1001

  #define VICAM_BYTES_PER_PIXEL   3
  #define VICAM_MAX_READ_SIZE     (512*242+128)
@@ -1254,6 +1257,7 @@ static struct video_device vicam_templat
  /* table of devices that work with this driver */
  static struct usb_device_id vicam_table[] = {
  	{USB_DEVICE(USB_VICAM_VENDOR_ID, USB_VICAM_PRODUCT_ID)},
+	{USB_DEVICE(USB_COMPRO_VENDOR_ID, USB_COMPRO_PRODUCT_ID)},
  	{}			/* Terminating entry */
  };


-- 
VGER BF report: U 0.954643
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/