linux-kernel - Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3k64lm87r.fsf@defiant.localdomain>
Date:	Sun, 03 Sep 2006 14:43:20 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Alexey Kuznetsov <kuznet@....inr.ac.ru>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM

Herbert Xu <herbert@...dor.apana.org.au> writes:

> [NET]: Drop tx lock in dev_watchdog_up
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -238,9 +238,7 @@ void __netdev_watchdog_up(struct net_dev
>  
>  static void dev_watchdog_up(struct net_device *dev)
>  {
> -	netif_tx_lock_bh(dev);
>  	__netdev_watchdog_up(dev);
> -	netif_tx_unlock_bh(dev);
>  }
>  
>  static void dev_watchdog_down(struct net_device *dev)

Many thanks for looking into this. The lockdep warning is gone now.
-- 
Krzysztof Halasa

-- 
VGER BF report: H 3.43998e-11
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/