linux-kernel - Re: [PATCH 08/16] GFS2: Resource group code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0609041637500.17279@yvahk01.tjqt.qr>
Date:	Mon, 4 Sep 2006 16:50:34 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Steven Whitehouse <swhiteho@...hat.com>
cc:	linux-kernel@...r.kernel.org,
	Russell Cattelan <cattelan@...hat.com>,
	David Teigland <teigland@...hat.com>,
	Ingo Molnar <mingo@...e.hu>, hch@...radead.org
Subject: Re: [PATCH 08/16] GFS2: Resource group code


>+#define BFITNOENT 0xFFFFFFFF

See previous mail, (uint32_t)-1 / (uint32_t)~0 or leave it.

>+static inline int rgrp_contains_block(struct gfs2_rindex *ri, uint64_t block)
>+{
>+	uint64_t first = ri->ri_data0;
>+	uint64_t last = first + ri->ri_data;
>+	return !!(first <= block && block < last);
>+}

No need for the !!, the expression !! is operating on is already a boolean.
IOW,

	return first <= block && block < last;


>+/**
>+ * gfs2_alloc_put - throw away the struct gfs2_alloc for an inode
>+ * @ip: the inode
>+ *
>+ */
>+
>+void gfs2_alloc_put(struct gfs2_inode *ip)
>+{
>+	return;
>+}

Missing some code? Code that comes later?


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/