linux-kernel - Re: [PATCH] RTC: more XSTP/VDET support for rtc-rs5c348 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060904155847.4b32539b@inspiron>
Date:	Mon, 4 Sep 2006 15:58:47 +0200
From:	Alessandro Zummo <alessandro.zummo@...ertech.it>
To:	Atsushi Nemoto <anemo@....ocn.ne.jp>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] RTC: more XSTP/VDET support for rtc-rs5c348 driver

On Mon, 04 Sep 2006 22:22:22 +0900 (JST)
Atsushi Nemoto <anemo@....ocn.ne.jp> wrote:

> If the chip detected "oscillator stop" condition, show an warning
> message.  And initialize it with the Epoch time instead of leaving it
> with unknown date/time.
> 
> Signed-off-by: Atsushi Nemoto <anemo@....ocn.ne.jp>

Signed-off-by: Alessandro Zummo <a.zummo@...ertech.it>

> diff --git a/drivers/rtc/rtc-rs5c348.c b/drivers/rtc/rtc-rs5c348.c
> index 0964d1d..2558906 100644
> --- a/drivers/rtc/rtc-rs5c348.c
> +++ b/drivers/rtc/rtc-rs5c348.c
> @@ -23,7 +23,7 @@ #include <linux/rtc.h>
>  #include <linux/workqueue.h>
>  #include <linux/spi/spi.h>
>  
> -#define DRV_VERSION "0.1"
> +#define DRV_VERSION "0.2"
>  
>  #define RS5C348_REG_SECS	0
>  #define RS5C348_REG_MINS	1
> @@ -175,8 +175,15 @@ static int __devinit rs5c348_probe(struc
>  		goto kfree_exit;
>  	if (ret & (RS5C348_BIT_XSTP | RS5C348_BIT_VDET)) {
>  		u8 buf[2];
> +		struct rtc_time tm;
>  		if (ret & RS5C348_BIT_VDET)
>  			dev_warn(&spi->dev, "voltage-low detected.\n");
> +		if (ret & RS5C348_BIT_XSTP)
> +			dev_warn(&spi->dev, "oscillator-stop detected.\n");
> +		rtc_time_to_tm(0, &tm);	/* 1970/1/1 */
> +		ret = rs5c348_rtc_set_time(&spi->dev, &tm);
> +		if (ret < 0)
> +			goto kfree_exit;
>  		buf[0] = RS5C348_CMD_W(RS5C348_REG_CTL2);
>  		buf[1] = 0;
>  		ret = spi_write_then_read(spi, buf, sizeof(buf), NULL, 0);


-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Turin, Italy

  http://www.towertech.it

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/