[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060904184156.GY4416@stusta.de>
Date: Mon, 4 Sep 2006 20:41:56 +0200
From: Adrian Bunk <bunk@...sta.de>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Matthew Wilcox <matthew@....cx>, Andrew Morton <akpm@...l.org>,
Sukadev Bhattiprolu <sukadev@...ibm.com>,
linux-kernel@...r.kernel.org, parisc-linux@...isc-linux.org
Subject: Re: [PATCH] Fix conflict with the is_init identifier on parisc
On Mon, Sep 04, 2006 at 12:24:27PM -0600, Eric W. Biederman wrote:
> Matthew Wilcox <matthew@....cx> writes:
>
> > On Mon, Sep 04, 2006 at 01:41:30PM +0200, Adrian Bunk wrote:
> >> pidspace-is_init.patch causes the following compile error on parisc:
> >>
> >> <-- snip -->
> >>
> >> ...
> >> CC arch/parisc/kernel/module.o
> >>
> > /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/arch/parisc/kernel/module.c:76:
> > error: conflicting types for 'is_init'
> >> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc5-mm1/include/linux/sched.h:1090:
> > error: previous definition of 'is_init' was here
> >> make[2]: *** [arch/parisc/kernel/module.o] Error 1
> >>
> >> <-- snip -->
> >
> > Looks like ia64 calls the same function in_init(). I'm tempted to
> > change parisc to have the same name.
>
> How does the following patch look?
> Since I don't have a parisc compiler so I haven't compile tested it.
> But it is a simple substitute and replace and I can't see any problems
> by inspection so it should work.
>...
Thanks, I can confirm it fixes the compilation.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists