linux-kernel - Re: Linux 2.6.18-rc6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060904223153.GK13238@bayes.mathematik.tu-chemnitz.de>
Date:	Tue, 5 Sep 2006 00:31:54 +0200
From:	Steffen Klassert <klassert@...hematik.tu-chemnitz.de>
To:	Gene Heskett <gene.heskett@...izon.net>,
	Linus Torvalds <torvalds@...l.org>,
	Jeremy Roberson <jroberson@...ocalcomp.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Linux 2.6.18-rc6

On Mon, Sep 04, 2006 at 07:05:53AM -0400, Gene Heskett wrote:
> On Sunday 03 September 2006 22:42, Linus Torvalds wrote:
> >Things are definitely calming down, and while I'm not ready to call it a
> >final 2.6.18 yet, this migt be the last -rc.
> >
> It has one new build warning, no idea if show stopper or not:
> ----------
> drivers/usb/input/hid-core.c:1447:1: warning: "USB_DEVICE_ID_GTCO_404" 
> redefined
> drivers/usb/input/hid-core.c:1446:1: warning: this is the location of the 
> previous definition
> ----------
> until after I boot to it...
> 
> And that didn't seem to effect the mouse.  Other usb stuff has not been 
> exersized yet.

The offending patch is 
hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist

If one looks at this patch it seems to be just a typo. 
The patch below fixes at least the warning.

--- vanilla-2.6.18-rc6/drivers/usb/input/hid-core.c	2006-09-04 04:19:48.000000000 +0200
+++ linux-2.6.18-rc6/drivers/usb/input/hid-core.c	2006-09-04 23:53:10.000000000 +0200
@@ -1444,7 +1444,7 @@
 #define USB_DEVICE_ID_GTCO_402		0x0402
 #define USB_DEVICE_ID_GTCO_403		0x0403
 #define USB_DEVICE_ID_GTCO_404		0x0404
-#define USB_DEVICE_ID_GTCO_404		0x0405
+#define USB_DEVICE_ID_GTCO_405		0x0405
 #define USB_DEVICE_ID_GTCO_500		0x0500
 #define USB_DEVICE_ID_GTCO_501		0x0501
 #define USB_DEVICE_ID_GTCO_502		0x0502
@@ -1657,7 +1657,7 @@
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_402, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_403, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
-	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
+	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_405, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_500, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_501, HID_QUIRK_IGNORE },
 	{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_502, HID_QUIRK_IGNORE },
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/