linux-kernel - 2.6.18-rc5-mm1 ich_pata_cbl_detect returns a value despite being void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060904120405.GC1581@slug>
Date:	Mon, 4 Sep 2006 12:04:05 +0000
From:	Frederik Deweerdt <deweerdt@...e.fr>
To:	jeff@...zik.org
Cc:	alan@...rguk.ukuu.org.uk, akpm@...l.org,
	linux-kernel@...r.kernel.org
Subject: 2.6.18-rc5-mm1 ich_pata_cbl_detect returns a value despite being void

Hi,

Compiling 2.6.18-rc5-mm1 issues the following warning:
  CC      drivers/ata/ata_piix.o
  drivers/ata/ata_piix.c: In function 'ich_pata_cbl_detect':
  drivers/ata/ata_piix.c:612: warning: 'return' with a value, in
  function returning void

This was introduced by the
libata-add-40pin-short-cable-support-honour-drive.patch.
The attached patch fixes the issue by assigning ap->cbl.

Regards,
Frederik

Signed-off-by: Frederik Deweerdt <deweerdt@...e.fr>
diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
index e4d7873..c9c8341 100644
--- a/drivers/ata/ata_piix.c
+++ b/drivers/ata/ata_piix.c
@@ -608,8 +608,10 @@ static void ich_pata_cbl_detect(struct a
 	while (lap->device) {
 		if (lap->device == pdev->device &&
 		    lap->subvendor == pdev->subsystem_vendor &&
-		    lap->subdevice == pdev->subsystem_device)
-		    	return ATA_CBL_PATA40_SHORT;
+		    lap->subdevice == pdev->subsystem_device) {
+			ap->cbl = ATA_CBL_PATA40_SHORT;
+		    	return;
+		}
 		lap++;
 	}
 

-- 
VGER BF report: U 0.500037
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/