linux-kernel - Re: [PATCH][RFC] request_firmware examples and MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1157366503.30801.14.camel@localhost.localdomain>
Date:	Mon, 04 Sep 2006 11:41:42 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Victor Hugo <victor@...go.net>
Cc:	linux-kernel@...r.kernel.org, greg@...ah.com
Subject: Re: [PATCH][RFC] request_firmware examples and MODULE_FIRMWARE

Ar Llu, 2006-09-04 am 01:39 -0700, ysgrifennodd Victor Hugo:
> That said, here's the patch...
> 
> tatic void sample_firmware_load(char *firmware, int size)
+{
+       u8 buf[size + 1];
+       memcpy(buf, firmware, size);

Please don't use this GNUism in the kernel code. It makes it very hard
to tell how much is being put on the (limited) stack. Better to use
kmalloc explicitly or a fixed size.

Rest looks sane.


-- 
VGER BF report: H 1.48569e-10
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/