linux-kernel - Re: [PATCH 23/26] Dynamic kernel command-line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200609052035.51229.alon.barlev@gmail.com>
Date:	Tue, 5 Sep 2006 20:35:50 +0300
From:	Alon Bar-Lev <alon.barlev@...il.com>
To:	"Randy.Dunlap" <rdunlap@...otime.net>
Cc:	Andi Kleen <ak@...e.de>, Matt Domsch <Matt_Domsch@...l.com>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	johninsd@....rr.com, davej@...emonkey.org.uk, Riley@...liams.name,
	trini@...nel.crashing.org, davem@...emloft.net, ecd@...inaid.de,
	jj@...site.ms.mff.cuni.cz, anton@...ba.org, wli@...omorphy.com,
	lethal@...ux-sh.org, rc@....org.uk, spyro@....com, rth@...ddle.net,
	avr32@...el.com, hskinnemoen@...el.com, starvik@...s.com,
	ralf@...ux-mips.org, matthew@....cx, grundler@...isc-linux.org,
	geert@...ux-m68k.org, zippel@...ux-m68k.org, paulus@...ba.org,
	schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
	uclinux-v850@....nec.co.jp, chris@...kel.net
Subject: Re: [PATCH 23/26] Dynamic kernel command-line - um

On Tuesday 05 September 2006 20:24, Randy.Dunlap wrote:
> Please use tabs instead of spaces for indentation.

It was in the original file, didn't notice...

Here it is again...

1. Rename saved_command_line into boot_command_line.
2. Set command_line as __initdata.

Signed-off-by: Alon Bar-Lev <alon.barlev@...il.com>

---

diff -urNp linux-2.6.18-rc5-mm1.org/arch/um/include/user_util.h linux-2.6.18-rc5-mm1/arch/um/include/user_util.h
--- linux-2.6.18-rc5-mm1.org/arch/um/include/user_util.h	2006-06-18 04:49:35.000000000 +0300
+++ linux-2.6.18-rc5-mm1/arch/um/include/user_util.h	2006-09-03 23:47:03.000000000 +0300
@@ -38,7 +38,7 @@ extern unsigned long long highmem;
 
 extern char host_info[];
 
-extern char saved_command_line[];
+extern char __initdata boot_command_line[];
 
 extern unsigned long _stext, _etext, _sdata, _edata, __bss_start, _end;
 extern unsigned long _unprotected_end;
diff -urNp linux-2.6.18-rc5-mm1.org/arch/um/kernel/um_arch.c linux-2.6.18-rc5-mm1/arch/um/kernel/um_arch.c
--- linux-2.6.18-rc5-mm1.org/arch/um/kernel/um_arch.c	2006-09-03 18:56:51.000000000 +0300
+++ linux-2.6.18-rc5-mm1/arch/um/kernel/um_arch.c	2006-09-03 19:47:59.000000000 +0300
@@ -482,7 +482,7 @@ void __init setup_arch(char **cmdline_p)
 	atomic_notifier_chain_register(&panic_notifier_list,
 			&panic_exit_notifier);
 	paging_init();
-        strlcpy(saved_command_line, command_line, COMMAND_LINE_SIZE);
+	strlcpy(boot_command_line, command_line, COMMAND_LINE_SIZE);
  	*cmdline_p = command_line;
 	setup_hostinfo();
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/