linux-kernel - Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157429474.3915.14.camel@raven.themaw.net>
Date:	Tue, 05 Sep 2006 12:11:14 +0800
From:	Ian Kent <raven@...maw.net>
To:	David Howells <dhowells@...hat.com>
Cc:	Andrew Morton <akpm@...l.org>,
	Trond Myklebust <trond.myklebust@....uio.no>,
	torvalds@...l.org, steved@...hat.com,
	linux-fsdevel@...r.kernel.org, linux-cachefs@...hat.com,
	nfsv4@...ux-nfs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock
	sharing [try #13]

On Mon, 2006-09-04 at 14:46 +0100, David Howells wrote:
> Ian Kent <raven@...maw.net> wrote:
> 
> > This is the point I'm trying to make.
> > I'm able to reproduce this with exports that don't have "nohide".
> > The mkdir used to return EEXIST, possibly before getting to the EACCES
> > test. It appears to be a change in semantic behavior and I can't see
> > where it is coming from. autofs expects an EEXIST but not an EACCES and
> > so doesn't perform the mount. I could ignore the EACCES but that would
> > be cheating.
> 
> Here's something you can try:  Look in fs/nfs/dir.c.  Find nfs_lookup().  In
> there, find the following lines:
> 
> 	/* If we're doing an exclusive create, optimize away the lookup */
> 	if (nfs_is_exclusive_create(dir, nd))
> 		goto no_entry;
> 
> Comment that bit out and see what the effect it.

Yes.

Commenting this out results in the expected behavior.
No doubt this is because the following NFS lookup to the server returns
EEXIST which is then returned to userspace.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/