linux-kernel - Re: [PATCH 07/16] GFS2: Directory handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060905105813.GA8195@elte.hu>
Date:	Tue, 5 Sep 2006 12:58:13 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andreas Schwab <schwab@...e.de>
Cc:	Steven Whitehouse <swhiteho@...hat.com>,
	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	linux-kernel@...r.kernel.org,
	Russell Cattelan <cattelan@...hat.com>,
	David Teigland <teigland@...hat.com>, hch@...radead.org
Subject: Re: [PATCH 07/16] GFS2: Directory handling


* Andreas Schwab <schwab@...e.de> wrote:

> >> > >+	if (dent->de_inum.no_addr != 0 &&
> >> > >+	    be32_to_cpu(dent->de_hash) == name->hash &&
> >> > >+	    be16_to_cpu(dent->de_name_len) == name->len &&
> >> > >+	    memcmp((char *)(dent+1), name->name, name->len) == 0)
> >> > 
> >> > Nocast.
> >> > 
> >> ok
> >
> > actually, sizeof(*dent) != 1, so how can a non-casted memcmp be correct 
> > here?
> 
> How can the cast change anything?

yeah - i for a minute thought that the '+' is outside the cast - but it 
is inside.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/