linux-kernel - Re: [stable] [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060906204747.GA18780@kroah.com>
Date:	Wed, 6 Sep 2006 13:47:47 -0700
From:	Greg KH <greg@...ah.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Neil Brown <neilb@...e.de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>, Nix <nix@...eri.org.uk>,
	stable@...nel.org
Subject: Re: [stable] [2.6.17.8] NFS stall / BUG in UDP fragment processing / SKB trimming

On Sat, Aug 26, 2006 at 11:18:39AM +1000, Herbert Xu wrote:
> On Fri, Aug 25, 2006 at 04:03:16PM -0700, Greg KH wrote:
> > 
> > This patch doesn't apply at all to the latest 2.6.17-stable kernel tree.
> > Care to rediff it?
> 
> Hmm, I just rebased and it actually applied as is to 2.6.17.11 :)
> Anyway, here is the result:

No, are you sure you are using the right tree?

> diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
> index cff9c3a..d987a27 100644
> --- a/net/ipv4/ip_output.c
> +++ b/net/ipv4/ip_output.c
> @@ -946,7 +946,7 @@ alloc_new_skb:
>  				skb_prev->csum = csum_sub(skb_prev->csum,
>  							  skb->csum);
>  				data += fraggap;
> -				skb_trim(skb_prev, maxfraglen);
> +				pskb_trim_unique(skb_prev, maxfraglen);
>  			}

Oh wait, this is already in the queue, no wonder it's failing...  Sorry
about this, my fault...

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/