[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060906084021.GA30856@elte.hu>
Date: Wed, 6 Sep 2006 10:40:21 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Hua Zhong <hzhong@...il.com>
Cc: 'Heiko Carstens' <heiko.carstens@...ibm.com>,
'Andrew Morton' <akpm@...l.org>, linux-kernel@...r.kernel.org,
'Arjan van de Ven' <arjan@...radead.org>,
'Daniel Walker' <dwalker@...sta.com>
Subject: Re: lockdep oddity
* Hua Zhong <hzhong@...il.com> wrote:
> We are just trading accuracy for speed here.
no, we are trading _both_ accuracy and speed here! a global 'likeliness'
pointer for commonly executed codepaths is causing global cacheline
ping-pongs - which is as bad as it gets.
the right approach, which incidentally would also be perfectly accurate,
is to store an alloc_percpu()-ed pointer at the call site, not the
counter itself.
the current code needs more work before it can go upstream i think.
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists