linux-kernel - Re: [NEW PATCH] VIA IRQ quirk behaviour change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157629436.2369.7.camel@localhost.localdomain>
Date:	Thu, 07 Sep 2006 12:43:56 +0100
From:	Sergio Monteiro Basto <sergio@...giomb.no-ip.org>
To:	Daniel Drake <dsd@...too.org>
Cc:	Linus Torvalds <torvalds@...l.org>,
	Stian Jordet <liste@...det.net>, akpm@...l.org,
	jeff@...zik.org, greg@...ah.com, cw@...f.org, bjorn.helgaas@...com,
	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	harmon@....edu, len.brown@...el.com, vsu@...linux.ru
Subject: Re: [NEW PATCH] VIA IRQ quirk behaviour change

Hi, 
Sorry for the empty email before 

On Wed, 2006-09-06 at 23:47 -0400, Daniel Drake wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=6419#c19
> 
> Where's the patch?

on kernel 2.6.18-rc4 and
« Here is a patch which should fix the "host controller process error"  
problem:
http://marc.theaimsgroup.com/?l=linux-usb-devel&m=115435540308759&w=2

Alan Stern »



> This report seems to be inconclusive. Your USB problem (comment #19)
> was 
> clearly something to do with UHCI itself, whereas Stian's problem is 
> much more generic and outside the control of the USB HCD: nobody cared
> Plus the only issue related to IRQ routing on that bug is triggered
> by 
> the closed nvidia driver...
> 
> > About Linus patch I have to correct me about what I had write,
> > http://lkml.org/lkml/2005/9/27/113
> > «(it used to say "if we have an IO-APIC, don't do this" (my patch),
> now
> > it says "if this irq is bound to an IO-APIC, don't do this")»
> > Or my patch or the Linus patch, not both.
> 
> Sorry, I can't figure out what you are trying to say here. Can you 
> rephrase it?

the statment was write by Linus on http://lkml.org/lkml/2005/9/27/113
my patch don't quirk any device if we are working on IO-APIC,
Linus simply know if a interrupt is > 15 we are working on IO-APIC and
just don't quirk irq > 15 

> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c 
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -546,7 +546,10 @@ static void quirk_via_irq(struct pci_dev
> >  {
> >       u8 irq, new_irq;
> >  
> > -     new_irq = dev->irq & 0xf;
> > +     new_irq = dev->irq;
> > +     if (!new_irq || new_irq >= 15)
> > +             return;
> > +
> >       pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
> >       if (new_irq != irq) {
> > 
> > but I look to this Linus patch and I see 2 bugs
> > one should be > not >=
> 
> I think you might be right here. Firstly IRQ 15 is a legacy IRQ, 
> secondly the existing "&15" thing has no effect on IRQ 15 obviously.
> 
> > and new_irq after tests new_irq should be dev->irq & 0xf;
> > like this:
> > -     new_irq = dev->irq & 0xf;
> > +     new_irq = dev->irq;
> > +     if (!new_irq || new_irq > 15)
> > +             return;
> > +     new_irq = dev->irq & 0xf;
> >       pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
> >       if (new_irq != irq) {
> 
> No, there is no bug, think about the logic:
> 
> We bail out if dev->irq is higher than 15. Therefore when we get to
> the 
> lines of code in question, dev->irq is 15 or less. Performing a
> logical 
> AND operation with the value 15 (0xf) is going to have no effect at
> all.
> 
ok
Thanks,


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/