linux-kernel - Re: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature while sanity-checking an ATAPI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4500893D.6090907@pobox.com>
Date:	Thu, 07 Sep 2006 17:03:57 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Tejun Heo <htejun@...il.com>, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"J.A. Magallon" <jamagallon@....com>
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature
 while sanity-checking an ATAPI device

Andrew Morton wrote:
> On Thu, 7 Sep 2006 20:32:24 +0900
> Tejun Heo <htejun@...il.com> wrote:
> 
>> 0x848a in ID word 0 indicates CFA device iff the ID data is obtained
>> from IDENTIFY DEVICE.  For ATAPI devices, 0x848a in ID work 0
>> indicates valid ATAPI device.  Fix sanity check in ata_dev_read_id()
>> such that ATAPI devices reporting 0x848a in ID word 0 is not handled
>> as error.
>>
>> The problem is identified by J.A. Magallon with HL-DT-ST DVDRAM
>> GSA-4120B.
>>
>> Signed-off-by: Tejun Helo <htejun@...il.com>
>> Cc: J.A. Magallon <jamagallon@....com>
>> ---
>> Jeff, this is a regression and thus should go into .19.
> 
> You mean 2.6.18, yes?

Actually, it looks like it should indeed be 2.6.19 (libata #upstream), 
not 2.6.18 (libata #upstream-fixes).  Alan's "add compactflash support" 
patch isn't in 2.6.18-rc.

So, this should -not- be sent for 2.6.18.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/