linux-kernel - [patch -mm] s390: fix save_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060908121626.GC6913@osiris.boeblingen.de.ibm.com>
Date:	Fri, 8 Sep 2006 14:16:26 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...e.de>,
	Martin Schwidefsky <schwidefsky@...ibm.com>
Subject: [patch -mm] s390: fix save_stack_trace

From: Heiko Carstens <heiko.carstens@...ibm.com>

x86_64-mm-stacktrace-cleanup.patch reverses the logic in s390's
save_stack_trace incorrectly. Fix this.

Cc: Andi Kleen <ak@...e.de>
Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
From: Heiko Carstens <heiko.carstens@...ibm.com>
---

 arch/s390/kernel/stacktrace.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Index: linux-2.6.17/arch/s390/kernel/stacktrace.c
===================================================================
--- linux-2.6.17.orig/arch/s390/kernel/stacktrace.c	2006-09-08 13:44:44.000000000 +0200
+++ linux-2.6.17/arch/s390/kernel/stacktrace.c	2006-09-08 14:00:36.000000000 +0200
@@ -70,12 +70,12 @@
 	sp = save_context_stack(trace, &trace->skip, sp,
 				S390_lowcore.panic_stack - PAGE_SIZE,
 				S390_lowcore.panic_stack);
-	if ((sp != orig_sp) && trace->all_contexts)
+	if ((sp != orig_sp) && !trace->all_contexts)
 		return;
 	sp = save_context_stack(trace, &trace->skip, sp,
 				S390_lowcore.async_stack - ASYNC_SIZE,
 				S390_lowcore.async_stack);
-	if ((sp != orig_sp) && trace->all_contexts)
+	if ((sp != orig_sp) && !trace->all_contexts)
 		return;
 	if (task)
 		save_context_stack(trace, &trace->skip, sp,
@@ -85,5 +85,4 @@
 		save_context_stack(trace, &trace->skip, sp,
 				   S390_lowcore.thread_info,
 				   S390_lowcore.thread_info + THREAD_SIZE);
-	return;
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/