linux-kernel - Re: [PATCH RFC]: New termios take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157885180.2977.133.camel@pmac.infradead.org>
Date:	Sun, 10 Sep 2006 11:46:20 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH RFC]: New termios take 2

On Tue, 2006-09-05 at 17:14 +0100, Alan Cox wrote:
> +
> +#define TCGETS2                _IOR('T',0x2A, struct termios)
> +#define TCSETS2                _IOW('T',0x2B, struct termios)
> +#define TCSETSW2       _IOW('T',0x2C, struct termios)
> +#define TCSETSF2       _IOW('T',0x2D, struct termios)

So existing code compiled against this will be using the new 'struct
termios' but the old TCGETS. Should we rename the existing ioctl to 
TCGETS_OLD, and have TCGETS be the new one?

I suppose to a large extent it doesn't really matter as long as existing
C libraries happen to get it right -- and since the new structure only
has the new field added, the discrepancy shouldn't matter _too_ much.
But still...

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/