linux-kernel - Re: [PATCH] usb: Fixup usb so it uses struct pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1fyezclzq.fsf@ebiederm.dsl.xmission.com>
Date:	Sun, 10 Sep 2006 17:58:33 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Greg KH <greg@...ah.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Linux Containers <containers@...ts.osdl.org>,
	linux-usb-devel@...ts.sourceforge.net,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH] usb: Fixup usb so it uses struct pid

Greg KH <greg@...ah.com> writes:

> On Sat, Sep 09, 2006 at 10:42:10PM -0600, Eric W. Biederman wrote:
>> 
>> The problem by remember a user space process by it's pid it is
>> possible that the process will exit, pid wrap around will occur and a
>> different process will appear in it's place.  Holding a reference
>> to a struct pid avoid that problem, and paves the way
>> for implementing a pid namespace.
>> 
>> Also since usb is the only user of kill_proc_info_as_uid
>> rename kill_proc_info_as_uid to kill_pid_info_as_uid
>> and have the new version take a struct pid.
>> 
>> This patch is against 2.6.18-rc6-mm1.
>> 
>> Signed-off-by: Eric W. Biederman <ebiederm@...ssion.com>
>
> Looks good to me.
>
> Do you want me to take this in my tree, or will you be going through
> Andrew, like your other, related pid stuff?  If through Andrew, please
> feel free to add:
> 	Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

Sure.  I think going through Andrew makes sense.  As I probably have
a helper function or two in Andrews tree that hasn't hit wider distribution.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/