linux-kernel - Re: TG3 data corruption (TSO ?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1157990931.5436.5.camel@rh4>
Date:	Mon, 11 Sep 2006 09:08:51 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>
cc:	"Segher Boessenkool" <segher@...nel.crashing.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	"Linux Kernel list" <linux-kernel@...r.kernel.org>
Subject: Re: TG3 data corruption (TSO ?)

On Mon, 2006-09-11 at 15:52 +1000, Benjamin Herrenschmidt wrote:

> Looks like adding a sync to writel does fix it though... I'm trying to
> figure out which specific writel in the driver makes a difference. I'll
> then look into slicing those tcpdumps.

During runtime in the fast path, the only writel()'s we do in tg3 are to
the tx mbox, rx_mbox, and the interrupt mbox.  The interrupt mbox
shouldn't matter that much since it has no dependencies on other memory
writes before it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/