linux-kernel - Re: TG3 data corruption (TSO ?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157953925.31071.413.camel@localhost.localdomain>
Date:	Mon, 11 Sep 2006 15:52:05 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Michael Chan <mchan@...adcom.com>
Cc:	Segher Boessenkool <segher@...nel.crashing.org>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: TG3 data corruption (TSO ?)

On Sun, 2006-09-10 at 22:33 -0700, Michael Chan wrote:
> Benjamin Herrenschmidt wrote:
> 
> > I've done:
> > 
> > #define tw32_rx_mbox(reg, val)	do { wmb();
> tp->write32_rx_mbox(tp, reg, val); } while(0)
> > #define tw32_tx_mbox(reg, val)	do { wmb();
> tp->write32_tx_mbox(tp, reg, val); } while(0)
> > 
> 
> That should do it.
> 
> I think we need those tcpdump after all.  Can you send it to me?

Looks like adding a sync to writel does fix it though... I'm trying to
figure out which specific writel in the driver makes a difference. I'll
then look into slicing those tcpdumps.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/