linux-kernel - Re: Spinlock debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Sep 2006 15:04:27 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergei Organov <osv@...ad.com>
Cc:	Andrew Bird <ajb@...eresystems.co.uk>, linux-kernel@...r.kernel.org
Subject: Re: Spinlock debugging

Ar Maw, 2006-09-12 am 17:31 +0400, ysgrifennodd Sergei Organov:
> Alan Cox <alan@...rguk.ukuu.org.uk> writes:
> [...]
> > So all you need in your IRQ handler is
> >
> > 	if (tty_insert_flip_string(tty, buf, size))
> > 		tty_flip_buffer_push(tty);
> 
> What is the purpose of the "if" in the above code?  is push with no data
> in the buffer dangerous? Or is it just optimization of
> almost-never-taken path? ;)

Sorry..replied to sender only

It's an optimisation and you are right it may well not even be worth
doing

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/