linux-kernel - Re: [PATCH 2/2] display: Driver ks0108 and cfag12864b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <653402b90609111937i1d986331kc5ed167cb08831b7@mail.gmail.com>
Date:	Tue, 12 Sep 2006 04:37:53 +0200
From:	"Miguel Ojeda" <maxextreme@...il.com>
To:	"Alexey Dobriyan" <adobriyan@...il.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] display: Driver ks0108 and cfag12864b

On 9/12/06, Alexey Dobriyan <adobriyan@...il.com> wrote:
>
> arrrrggg....  I'm in the middle of reading every module_init and every
> module_exit func, and this starts getting really annoying....
>

Anyway, thank you for you time reviewing it. :)


>         5. In case of error during initialization, error code SHOULD be
>            propagated as is to upper layers, either via direct
>            assignment/return or via decoding from pointer.
>

What do you mean? I thought returning the error code was enough.


>         6. Error messages SHOULD start with short unique prefix specific to
>            driver. Module name without .o and .ko is fine.

They do 8)

#define PRINTK_PREFIX PRINTK_INFO NAME ": "

printk(PRINTK_PREFIX "Init... ");

Then, if a error appears: printk("ERROR - kmalloc\n");

Final string: "<i>cfag12864b: Init... ERROR - kmalloc"

The only bad point: If some other printk is called from other module
between. Should I change it?


    Miguel Ojeda
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/