[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20060912030029.GD24676@in.ibm.com>
Date: Tue, 12 Sep 2006 08:30:29 +0530
From: Ankita Garg <ankita@...ibm.com>
To: Andrew Morton <akpm@...l.org>
Cc: maneesh@...ibm.com, fernando@....ntt.co.jp,
linux-kernel@...r.kernel.org
Subject: Re: [RFC] Linux Kernel Dump Test Module
On Fri, Sep 08, 2006 at 12:42:44AM -0700, Andrew Morton wrote:
> On Thu, 7 Sep 2006 19:23:29 +0530
> Ankita Garg <ankita@...ibm.com> wrote:
>
> > +#include<linux/ide.h>
>
> s390 doesn't have this, so it breaks the build.
>
There could be two ways to solve the build issue on s390. One is to
conditionally include the "ide.h" file depending on whether CONFIG_IDE is
defined. The second method would be to make LKDTM dependent on IDE. But this
approach is not right as it would prevent usage of the module on s390
completely.
> And #include is followed by a space, please.
Done.
Thanks,
Ankita
View attachment "lkdtm-s390.patch" of type "text/plain" (1804 bytes)
Powered by blists - more mailing lists